From 8ae711867d1bc96c680ee21f738100b55cb5f183 Mon Sep 17 00:00:00 2001
From: Arthur Belleville <arthur.belleville@datadoghq.com>
Date: Thu, 2 Apr 2026 19:57:39 +0200
Subject: [PATCH] fix(pwa): address code review findings

- Fix includeAssets paths (remove incorrect public/ prefix)
- Add navigateFallback for SPA deep link resilience
- Move InstallBanner inside authenticated routes only

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
---
 apps/main/src/App.tsx    | 2 +-
 apps/main/vite.config.ts | 7 ++++---
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/apps/main/src/App.tsx b/apps/main/src/App.tsx
index 2abcf96..f92e874 100644
--- a/apps/main/src/App.tsx
+++ b/apps/main/src/App.tsx
@@ -32,6 +32,7 @@ const Routes = () => {
     return (
       <UserStoreProvider>
         <UpgradeBlockProvider>
+          <InstallBanner />
           <PendingSignupCheckout />
           <PlanAnnouncement />
           <UpgradePanel />
@@ -55,7 +56,6 @@ export const App = () => {
         <Toaster />
         <Router>
           <div className="min-h-screen bg-background">
-            <InstallBanner />
             <Routes />
             {showBanner && (
               <CookieBanner
diff --git a/apps/main/vite.config.ts b/apps/main/vite.config.ts
index e108772..90647d4 100644
--- a/apps/main/vite.config.ts
+++ b/apps/main/vite.config.ts
@@ -22,9 +22,9 @@ export default defineConfig(({ mode }) => {
       registerType: "autoUpdate",
       injectRegister: false,
       includeAssets: [
-        "public/icon.jpg",
-        "public/logo_dark.png",
-        "public/logo_white.png",
+        "icon.jpg",
+        "logo_dark.png",
+        "logo_white.png",
       ],
       manifest: {
         name: mode === "staging" ? "XTablo (Staging)" : "XTablo",
@@ -57,6 +57,7 @@ export default defineConfig(({ mode }) => {
       workbox: {
         globPatterns: ["**/*.{js,css,html,ico,png,jpg,svg,woff,woff2}"],
         globIgnores: ["**/*.map"],
+        navigateFallback: "index.html",
       },
     })
   );