fix(pwa): address code review findings

- Fix includeAssets paths (remove incorrect public/ prefix)
- Add navigateFallback for SPA deep link resilience
- Move InstallBanner inside authenticated routes only

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Arthur Belleville 2026-04-02 19:57:39 +02:00
parent 8e6e8b6d71
commit 8ae711867d
No known key found for this signature in database
2 changed files with 5 additions and 4 deletions

View file

@ -32,6 +32,7 @@ const Routes = () => {
return (
<UserStoreProvider>
<UpgradeBlockProvider>
<InstallBanner />
<PendingSignupCheckout />
<PlanAnnouncement />
<UpgradePanel />
@ -55,7 +56,6 @@ export const App = () => {
<Toaster />
<Router>
<div className="min-h-screen bg-background">
<InstallBanner />
<Routes />
{showBanner && (
<CookieBanner

View file

@ -22,9 +22,9 @@ export default defineConfig(({ mode }) => {
registerType: "autoUpdate",
injectRegister: false,
includeAssets: [
"public/icon.jpg",
"public/logo_dark.png",
"public/logo_white.png",
"icon.jpg",
"logo_dark.png",
"logo_white.png",
],
manifest: {
name: mode === "staging" ? "XTablo (Staging)" : "XTablo",
@ -57,6 +57,7 @@ export default defineConfig(({ mode }) => {
workbox: {
globPatterns: ["**/*.{js,css,html,ico,png,jpg,svg,woff,woff2}"],
globIgnores: ["**/*.map"],
navigateFallback: "index.html",
},
})
);